Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 3/3] genirq: Do not test disabled IRQs with DEBUG_SHIRQ | Date | Wed, 17 Jun 2020 11:30:44 +0200 |
| |
Mark Brown <broonie@kernel.org> writes: > On Tue, Jun 16, 2020 at 12:11:17PM +0200, Krzysztof Kozlowski wrote: >> On Mon, Jun 15, 2020 at 01:08:44PM +0100, Mark Brown wrote: >> > On Mon, Jun 15, 2020 at 10:07:19AM +0200, Krzysztof Kozlowski wrote: >> > > Testing events during freeing of disabled shared interrupts >> > > (CONFIG_DEBUG_SHIRQ) leads to false positives. The driver disabled >> > > interrupts on purpose to be sure that they will not fire during device >> > > removal. > >> > Surely the whole issue with shared IRQs that's being tested for here is >> > that when the interrupt is shared some other device connected to the >> > same interrupt line may trigger an interrupt regardless of what's going >> > on with this device? > >> Yes. However if that device disabled the interrupt, it should not be >> fired for other users. In such case the testing does not point to a >> real issue. > > To be honest I'd say that if you're disabling a shared interrupt that's > a bit of an issue regardless of anything else that's going on, it'll > disrupt other devices connected to it.
Correct.
Shared interrupts are broken by design and I really can't understand why hardware people still insist on them.
Thanks,
tglx
| |