Messages in this thread | | | Subject | Re: [PATCH v3 2/2] phy: bcm63xx-usbh: Add BCM63xx USBH driver | From | Philipp Zabel <> | Date | Wed, 17 Jun 2020 11:26:49 +0200 |
| |
Hi Álvaro,
On Tue, 2020-06-16 at 20:45 +0200, Álvaro Fernández Rojas wrote: > Add BCM63xx USBH PHY driver for BMIPS. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > v3: introduce changes suggested by Florian: > - Add support for device mode. > v2: introduce changes suggested by Florian: > - Drop OF dependency (use device_get_match_data). > - Drop __initconst from variant tables. > - Use devm_clk_get_optional. > > drivers/phy/broadcom/Kconfig | 9 + > drivers/phy/broadcom/Makefile | 1 + > drivers/phy/broadcom/phy-bcm63xx-usbh.c | 456 ++++++++++++++++++++++++ > 3 files changed, 466 insertions(+) > create mode 100644 drivers/phy/broadcom/phy-bcm63xx-usbh.c > [...] > diff --git a/drivers/phy/broadcom/phy-bcm63xx-usbh.c b/drivers/phy/broadcom/phy-bcm63xx-usbh.c > new file mode 100644 > index 000000000000..584807205166 > --- /dev/null > +++ b/drivers/phy/broadcom/phy-bcm63xx-usbh.c > @@ -0,0 +1,456 @@ [...] > + usbh->reset = devm_reset_control_get(dev, NULL);
Please use devm_reset_control_get_exclusive() instead when requesting exclusive reset controls.
> + if (IS_ERR(usbh->reset)) { > + if (PTR_ERR(usbh->reset) != -EPROBE_DEFER) > + dev_err(dev, "failed to get reset\n"); > + return PTR_ERR(usbh->reset); > + }
regards Philipp
| |