lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] KVM: VMX: Remove vcpu_vmx's defunct copy of host_pkru
    Date
    Sean Christopherson <sean.j.christopherson@intel.com> writes:

    > Remove vcpu_vmx.host_pkru, which got left behind when PKRU support was
    > moved to common x86 code.
    >
    > No functional change intended.
    >
    > Fixes: 37486135d3a7b ("KVM: x86: Fix pkru save/restore when guest CR4.PKE=0, move it to x86.c")
    > Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
    > ---
    > arch/x86/kvm/vmx/vmx.h | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/arch/x86/kvm/vmx/vmx.h b/arch/x86/kvm/vmx/vmx.h
    > index 8a83b5edc820..639798e4a6ca 100644
    > --- a/arch/x86/kvm/vmx/vmx.h
    > +++ b/arch/x86/kvm/vmx/vmx.h
    > @@ -288,8 +288,6 @@ struct vcpu_vmx {
    >
    > u64 current_tsc_ratio;
    >
    > - u32 host_pkru;
    > -
    > unsigned long host_debugctlmsr;
    >
    > /*

    (Is there a better [automated] way to figure out whether the particular
    field is being used or not than just dropping it and trying to compile
    the whole thing? Leaving #define-s, configs,... aside ...)

    Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

    --
    Vitaly

    \
     
     \ /
      Last update: 2020-06-17 11:20    [W:6.999 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site