Messages in this thread | | | Subject | Re: [PATCH] [net/sched]: Remove redundant condition in qdisc_graft | From | Eric Dumazet <> | Date | Wed, 17 Jun 2020 20:43:24 -0700 |
| |
On 6/17/20 6:23 PM, Gaurav Singh wrote: > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com>
Two Signed-off-by ?
> > Fix build errors
Your patch does not fix a build error.
> > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> > --- > net/sched/sch_api.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sched/sch_api.c b/net/sched/sch_api.c > index 9a3449b56bd6..be93ebcdb18d 100644 > --- a/net/sched/sch_api.c > +++ b/net/sched/sch_api.c > @@ -1094,7 +1094,7 @@ static int qdisc_graft(struct net_device *dev, struct Qdisc *parent, > > /* Only support running class lockless if parent is lockless */ > if (new && (new->flags & TCQ_F_NOLOCK) && > - parent && !(parent->flags & TCQ_F_NOLOCK)) > + !(parent->flags & TCQ_F_NOLOCK)) > qdisc_clear_nolock(new); > > if (!cops || !cops->graft) >
| |