lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 373/388] drm/ast: fix missing break in switch statement for format->cpp[0] case 4
    Date
    From: Colin Ian King <colin.king@canonical.com>

    [ Upstream commit 291ddeb621e4a9f1ced8302a777fbd7fbda058c6 ]

    Currently the switch statement for format->cpp[0] value 4 assigns
    color_index which is never read again and then falls through to the
    default case and returns. This looks like a missing break statement
    bug. Fix this by adding a break statement.

    Addresses-Coverity: ("Unused value")
    Fixes: 259d14a76a27 ("drm/ast: Split ast_set_vbios_mode_info()")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
    Tested-by: Thomas Zimmermann <tzimmermann@suse.de>
    Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
    Link: https://patchwork.freedesktop.org/patch/msgid/20200610115804.1132338-1-colin.king@canonical.com
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/gpu/drm/ast/ast_mode.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
    index cdd6c46d6557..479fc60b6c93 100644
    --- a/drivers/gpu/drm/ast/ast_mode.c
    +++ b/drivers/gpu/drm/ast/ast_mode.c
    @@ -226,6 +226,7 @@ static void ast_set_vbios_color_reg(struct ast_private *ast,
    case 3:
    case 4:
    color_index = TrueCModeIndex;
    + break;
    default:
    return;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 04:56    [W:4.195 / U:0.724 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site