lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 191/388] um: do not evaluate compiler's library path when cleaning
    Date
    From: Masahiro Yamada <masahiroy@kernel.org>

    [ Upstream commit 7e49afc03212010d0ee27532a75cfeb0125bd868 ]

    Since commit a83e4ca26af8 ("kbuild: remove cc-option switch from
    -Wframe-larger-than="), 'make ARCH=um clean' emits an error message
    as follows:

    $ make ARCH=um clean
    gcc: error: missing argument to '-Wframe-larger-than='

    We do not care compiler flags when cleaning.

    Use the '=' operator for lazy expansion because we do not use
    LDFLAGS_pcap.o or LDFLAGS_vde.o when cleaning.

    While I was here, I removed the redundant -r option because it
    already exists in the recipe.

    Fixes: a83e4ca26af8 ("kbuild: remove cc-option switch from -Wframe-larger-than=")
    Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
    Tested-by: Nathan Chancellor <natechancellor@gmail.com> [build]
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    arch/um/drivers/Makefile | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/arch/um/drivers/Makefile b/arch/um/drivers/Makefile
    index a290821e355c..2a249f619467 100644
    --- a/arch/um/drivers/Makefile
    +++ b/arch/um/drivers/Makefile
    @@ -18,9 +18,9 @@ ubd-objs := ubd_kern.o ubd_user.o
    port-objs := port_kern.o port_user.o
    harddog-objs := harddog_kern.o harddog_user.o

    -LDFLAGS_pcap.o := -r $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libpcap.a)
    +LDFLAGS_pcap.o = $(shell $(CC) $(KBUILD_CFLAGS) -print-file-name=libpcap.a)

    -LDFLAGS_vde.o := -r $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)
    +LDFLAGS_vde.o = $(shell $(CC) $(CFLAGS) -print-file-name=libvdeplug.a)

    targets := pcap_kern.o pcap_user.o vde_kern.o vde_user.o

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 04:56    [W:2.534 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site