lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.7 184/388] remoteproc/mediatek: fix invalid use of sizeof in scp_ipi_init()
    Date
    From: Wei Yongjun <weiyongjun1@huawei.com>

    [ Upstream commit 8096f80a5c09b716be207eb042c4e40d6cdefbd2 ]

    sizeof() when applied to a pointer typed expression gives the
    size of the pointer, not that of the pointed data.

    Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
    Fixes: 63c13d61eafe ("remoteproc/mediatek: add SCP support for mt8183")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
    Link: https://lore.kernel.org/r/20200509084237.36293-1-weiyongjun1@huawei.com
    Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/remoteproc/mtk_scp.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
    index 2bead57c9cf9..ac13e7b046a6 100644
    --- a/drivers/remoteproc/mtk_scp.c
    +++ b/drivers/remoteproc/mtk_scp.c
    @@ -132,8 +132,8 @@ static int scp_ipi_init(struct mtk_scp *scp)
    (struct mtk_share_obj __iomem *)(scp->sram_base + recv_offset);
    scp->send_buf =
    (struct mtk_share_obj __iomem *)(scp->sram_base + send_offset);
    - memset_io(scp->recv_buf, 0, sizeof(scp->recv_buf));
    - memset_io(scp->send_buf, 0, sizeof(scp->send_buf));
    + memset_io(scp->recv_buf, 0, sizeof(*scp->recv_buf));
    + memset_io(scp->send_buf, 0, sizeof(*scp->send_buf));

    return 0;
    }
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 04:42    [W:2.973 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site