lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 179/266] USB: gadget: udc: s3c2410_udc: Remove pointless NULL check in s3c2410_udc_nuke
    Date
    From: Nathan Chancellor <natechancellor@gmail.com>

    [ Upstream commit 7a0fbcf7c308920bc6116b3a5fb21c8cc5fec128 ]

    Clang warns:

    drivers/usb/gadget/udc/s3c2410_udc.c:255:11: warning: comparison of
    address of 'ep->queue' equal to a null pointer is always false
    [-Wtautological-pointer-compare]
    if (&ep->queue == NULL)
    ~~~~^~~~~ ~~~~
    1 warning generated.

    It is not wrong, queue is not a pointer so if ep is not NULL, the
    address of queue cannot be NULL. No other driver does a check like this
    and this check has been around since the driver was first introduced,
    presumably with no issues so it does not seem like this check should be
    something else. Just remove it.

    Commit afe956c577b2d ("kbuild: Enable -Wtautological-compare") exposed
    this but it is not the root cause of the warning.

    Fixes: 3fc154b6b8134 ("USB Gadget driver for Samsung s3c2410 ARM SoC")
    Link: https://github.com/ClangBuiltLinux/linux/issues/1004
    Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
    Reported-by: kbuild test robot <lkp@intel.com>
    Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
    Signed-off-by: Felipe Balbi <balbi@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/usb/gadget/udc/s3c2410_udc.c | 4 ----
    1 file changed, 4 deletions(-)

    diff --git a/drivers/usb/gadget/udc/s3c2410_udc.c b/drivers/usb/gadget/udc/s3c2410_udc.c
    index f82208fbc249..5dcc0692b95c 100644
    --- a/drivers/usb/gadget/udc/s3c2410_udc.c
    +++ b/drivers/usb/gadget/udc/s3c2410_udc.c
    @@ -251,10 +251,6 @@ static void s3c2410_udc_done(struct s3c2410_ep *ep,
    static void s3c2410_udc_nuke(struct s3c2410_udc *udc,
    struct s3c2410_ep *ep, int status)
    {
    - /* Sanity check */
    - if (&ep->queue == NULL)
    - return;
    -
    while (!list_empty(&ep->queue)) {
    struct s3c2410_request *req;
    req = list_entry(ep->queue.next, struct s3c2410_request,
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 04:17    [W:4.060 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site