lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 190/266] ASoC: fix incomplete error-handling in img_i2s_in_probe.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit 25bf943e4e7b47282bd86ae7d39e039217ebb007 ]

    Function "pm_runtime_get_sync()" is not handled by "pm_runtime_put()"
    if "PTR_ERR(rst) == -EPROBE_DEFER". Fix this issue by adding
    "pm_runtime_put()" into this error path.

    Fixes: f65bb92ca12e ("ASoC: img-i2s-in: Add runtime PM")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Link: https://lore.kernel.org/r/20200525055011.31925-1-wu000273@umn.edu
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/img/img-i2s-in.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/sound/soc/img/img-i2s-in.c b/sound/soc/img/img-i2s-in.c
    index fdd2c73fd2fa..869fe0068cbd 100644
    --- a/sound/soc/img/img-i2s-in.c
    +++ b/sound/soc/img/img-i2s-in.c
    @@ -482,6 +482,7 @@ static int img_i2s_in_probe(struct platform_device *pdev)
    if (IS_ERR(rst)) {
    if (PTR_ERR(rst) == -EPROBE_DEFER) {
    ret = -EPROBE_DEFER;
    + pm_runtime_put(&pdev->dev);
    goto err_suspend;
    }

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 04:16    [W:4.114 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site