lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 074/172] PCI: v3-semi: Fix a memory leak in v3_pci_probe() error handling paths
    Date
    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    [ Upstream commit bca718988b9008d0d5f504e2d318178fc84958c1 ]

    If we fails somewhere in 'v3_pci_probe()', we need to free 'host'.

    Use the managed version of 'pci_alloc_host_bridge()' to do that easily.
    The use of managed resources is already widely used in this driver.

    Link: https://lore.kernel.org/r/20200418081637.1585-1-christophe.jaillet@wanadoo.fr
    Fixes: 68a15eb7bd0c ("PCI: v3-semi: Add V3 Semiconductor PCI host driver")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    [lorenzo.pieralisi@arm.com: commit log]
    Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
    Acked-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pci/controller/pci-v3-semi.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/pci/controller/pci-v3-semi.c b/drivers/pci/controller/pci-v3-semi.c
    index d219404bad92..9a86bb7448ac 100644
    --- a/drivers/pci/controller/pci-v3-semi.c
    +++ b/drivers/pci/controller/pci-v3-semi.c
    @@ -743,7 +743,7 @@ static int v3_pci_probe(struct platform_device *pdev)
    int ret;
    LIST_HEAD(res);

    - host = pci_alloc_host_bridge(sizeof(*v3));
    + host = devm_pci_alloc_host_bridge(dev, sizeof(*v3));
    if (!host)
    return -ENOMEM;

    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 03:28    [W:6.442 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site