lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 071/266] yam: fix possible memory leak in yam_init_driver
    Date
    From: Wang Hai <wanghai38@huawei.com>

    [ Upstream commit 98749b7188affbf2900c2aab704a8853901d1139 ]

    If register_netdev(dev) fails, free_netdev(dev) needs
    to be called, otherwise a memory leak will occur.

    Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
    Reported-by: Hulk Robot <hulkci@huawei.com>
    Signed-off-by: Wang Hai <wanghai38@huawei.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/hamradio/yam.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/hamradio/yam.c b/drivers/net/hamradio/yam.c
    index 71cdef9fb56b..5ab53e9942f3 100644
    --- a/drivers/net/hamradio/yam.c
    +++ b/drivers/net/hamradio/yam.c
    @@ -1133,6 +1133,7 @@ static int __init yam_init_driver(void)
    err = register_netdev(dev);
    if (err) {
    printk(KERN_WARNING "yam: cannot register net device %s\n", dev->name);
    + free_netdev(dev);
    goto error;
    }
    yam_devs[i] = dev;
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-06-18 03:22    [W:3.766 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site