lkml.org 
[lkml]   [2020]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH v4 2/3] dt-bindings: net: ethernet-phy: add enet-phy-clock-out-frequency
Date
Am Mittwoch, 17. Juni 2020, 23:33:25 CEST schrieb Heiko Stuebner:
> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>
> Some ethernet phys have a configurable clock output, so add a generic
> property to describe its target rate.
>
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>

just now Rob wrote for v3:

----- 8< ------
The correct thing to do here is make the phy a clock provider and then
the client side use 'assigned-clock-rate' to set the rate. That has the
advantage that it also describes the connection of the clock signal. You
might not need that for a simple case, but I could imagine needing that
in a more complex case.

Rob
----- 8< ------



> Documentation/devicetree/bindings/net/ethernet-phy.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-phy.yaml b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> index 9b1f1147ca36..4dcf93f1c555 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-phy.yaml
> @@ -84,6 +84,11 @@ properties:
> the turn around line low at end of the control phase of the
> MDIO transaction.
>
> + enet-phy-clock-out-frequency:
> + $ref: /schemas/types.yaml#definitions/uint32
> + description:
> + Frequency in Hz to set an available clock output to.
> +
> enet-phy-lane-swap:
> $ref: /schemas/types.yaml#definitions/flag
> description:
>




\
 
 \ /
  Last update: 2020-06-18 00:00    [W:0.279 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site