Messages in this thread | | | From | Denis Efremov <> | Subject | Re: [Cocci] [PATCH v3] coccinelle: api: add kzfree script | Date | Thu, 18 Jun 2020 00:42:33 +0300 |
| |
>> +@rp_memset depends on patch@ >> +expression E, size; >> +position p : script:python() { relevant(p) }; >> +type T; >> +@@ >> + >> +- memset((T)E, size)@p; > > This is missing a 0 argument. >
Thanks, I will send v4.
> > >> + ... when != E >> + when strict >> +( >> +- kfree(E); >> ++ kzfree(E); >> +| >> +- \(vfree\|kvfree\)(E); >> ++ kvfree_sensitive(E, size); >> +) > > I'm not sure why you want kzfree in the first case, but kvfree_sensitive > in the second case. >
As for now in kernel:
memset(E,0,...) && kfree(E) is kzfree()
There are no vzfree or kvzfree functions. Thus, we use kvfree_sensitive().
Maybe it's worth to wait for this patchset: https://lkml.org/lkml/2020/6/16/1163
With it the rule will use:
( - kfree(E); + kfree_sensitive(E); | - \(vfree\|kvfree\)(E); + kvfree_sensitive(E, size); )
Thanks, Denis
| |