Messages in this thread | | | Date | Tue, 16 Jun 2020 18:20:19 -0500 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v9 2/2] PCI: hip: Add handling of HiSilicon HIP PCIe controller errors |
| |
On Mon, Jun 15, 2020 at 11:15:52AM +0100, Shiju Jose wrote: > From: Yicong Yang <yangyicong@hisilicon.com> > > The HiSilicon HIP PCIe controller is capable of handling errors > on root port and perform port reset separately at each root port. > > Add error handling driver for HIP PCIe controller to log > and report recoverable errors. Perform root port reset and restore > link status after the recovery. > > Following are some of the PCIe controller's recoverable errors > 1. completion transmission timeout error. > 2. CRS retry counter over the threshold error. > 3. ECC 2 bit errors > 4. AXI bresponse/rresponse errors etc.
> +static int hisi_pcie_notify_error(struct notifier_block *nb, > + unsigned long event, void *data) > +{ > + struct acpi_hest_generic_data *gdata = data; > + const struct hisi_pcie_error_data *error_data = > + acpi_hest_get_payload(gdata); > + struct hisi_pcie_error_private *priv = > + container_of(nb, struct hisi_pcie_error_private, nb); > + struct platform_device *pdev = priv->pdev; > + struct device *dev = &pdev->dev; > + u8 socket; > + > + if (device_property_read_u8(dev, "socket", &socket)) > + return NOTIFY_DONE; > + > + if (!guid_equal((guid_t *)gdata->section_type, &hisi_pcie_sec_type) || > + error_data->socket_id != socket) > + return NOTIFY_DONE;
I think you have to verify the GUID first before you can even safely extract a struct hisi_pcie_error_private from the payload:
if (!guid_equal(...)) return NOTIFY_DONE;
priv = container_of(nb, struct hisi_pcie_error_private, nb); pdev = priv->pdev; dev = &pdev->dev;
if (device_property_read_u8(dev, "socket", &socket)) return NOTIFY_DONE;
if (error_data->socket_id != socket) return NOTIFY_DONE;
> + hisi_pcie_handle_error(pdev, error_data); > + > + return NOTIFY_OK; > +}
| |