Messages in this thread |  | | From | jim.cromie@gmail ... | Date | Tue, 16 Jun 2020 14:08:57 -0600 | Subject | Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar |
| |
On Tue, Jun 16, 2020 at 5:57 AM Petr Mladek <pmladek@suse.com> wrote: > > On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > > Current code expects "keyword" "arg" as 2 space separated words. > > Change to also accept "keyword:arg" and "keyword=arg" forms as well, > > and drop !(nwords%2) requirement. > > > > Then in rest of function, use new keyword,arg variables instead of > > word[i],word[i+1] > > I like the idea. But please allow only one form. IMHO, parameter=value > is a common way to pass values to commandline parameters. >
I dont see a basis to prefer one over the other. we already now accept " file foo.c:func " that might argue for file=foo:func but file:foo:func is what youd expect reading left-to-right
> Note that "keyword" and "arg" is strange naming, especially "arg". >
I think keyword is clear in context. query_term is suitable, but no better.
arg is pretty generic, without overloaded meaning like value ( like lvalue ? rvalue ?) almost as old as 'i', but generally a string (not an int) Is there an alternative you favor ?
> Best Regards, > Petr
|  |