lkml.org 
[lkml]   [2020]   [Jun]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] ASoC: tegra: Fix reference count leaks.
    From
    Date

    On 13/06/2020 21:44, wu000273@umn.edu wrote:
    > From: Qiushi Wu <wu000273@umn.edu>
    >
    > Calling pm_runtime_get_sync increments the counter even in case of
    > failure, causing incorrect ref count if pm_runtime_put is not called in
    > error handling paths. Call pm_runtime_put if pm_runtime_get_sync fails.
    >
    > Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    > ---
    > sound/soc/tegra/tegra30_ahub.c | 4 +++-
    > sound/soc/tegra/tegra30_i2s.c | 4 +++-
    > 2 files changed, 6 insertions(+), 2 deletions(-)
    >
    > diff --git a/sound/soc/tegra/tegra30_ahub.c b/sound/soc/tegra/tegra30_ahub.c
    > index 635eacbd28d4..156e3b9d613c 100644
    > --- a/sound/soc/tegra/tegra30_ahub.c
    > +++ b/sound/soc/tegra/tegra30_ahub.c
    > @@ -643,8 +643,10 @@ static int tegra30_ahub_resume(struct device *dev)
    > int ret;
    >
    > ret = pm_runtime_get_sync(dev);
    > - if (ret < 0)
    > + if (ret < 0) {
    > + pm_runtime_put(dev);
    > return ret;
    > + }
    > ret = regcache_sync(ahub->regmap_ahub);
    > ret |= regcache_sync(ahub->regmap_apbif);
    > pm_runtime_put(dev);
    > diff --git a/sound/soc/tegra/tegra30_i2s.c b/sound/soc/tegra/tegra30_i2s.c
    > index d59882ec48f1..db5a8587bfa4 100644
    > --- a/sound/soc/tegra/tegra30_i2s.c
    > +++ b/sound/soc/tegra/tegra30_i2s.c
    > @@ -567,8 +567,10 @@ static int tegra30_i2s_resume(struct device *dev)
    > int ret;
    >
    > ret = pm_runtime_get_sync(dev);
    > - if (ret < 0)
    > + if (ret < 0) {
    > + pm_runtime_put(dev);
    > return ret;
    > + }
    > ret = regcache_sync(i2s->regmap);
    > pm_runtime_put(dev);

    Thanks.

    Reviewed-by: Jon Hunter <jonathanh@nvidia.com>

    Cheers
    Jon

    --
    nvpublic

    \
     
     \ /
      Last update: 2020-06-16 21:43    [W:4.796 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site