| Subject | Re: [PATCH v2 0/4] spi: bcm63xx: add BMIPS support | From | Florian Fainelli <> | Date | Mon, 15 Jun 2020 09:27:47 -0700 |
| |
Hi Alvaro,
On 6/15/2020 2:09 AM, Álvaro Fernández Rojas wrote: > BCM63xx SPI and HSSPI controller are present on several BMIPS SoCs (BCM6318, > BCM6328, BCM6358, BCM6362, BCM6368 and BCM63268). > > v2: use devm_reset_control_get_exclusive
We would also need to write a binding document for these two controllers, as they appear to be missing, and this would document the reset property.
I also believe that you should be making this property optional since not all SoCs do have a dedicated reset controller line for SPI/HSSPI (if at all).
Thank you! -- Florian
|