[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2 10/24] dyndbg: refactor parse_linerange out of ddebug_parse_query
On Sat 2020-06-13 09:57:24, Jim Cromie wrote:
> make the code-block reusable to later handle "file foo.c:101-200" etc.

> This should be a 90%+ code-move, with minimal adaptations; reindent,
> and scafolding.

This sentence sounds like the author did some hidden
microoptimizations and potentially broke the code.
It made me nervous.

But in fact, I do not see any real change except that the variable
"first" does not longer need to be defined. So, it is just a code move.

In this case, I usually write:

This patch does not change the existing behavior.

Best Regards,

 \ /
  Last update: 2020-06-15 15:38    [W:0.181 / U:1.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site