| Date | Mon, 15 Jun 2020 15:37:40 +0200 | From | Petr Mladek <> | Subject | Re: [PATCH v2 10/24] dyndbg: refactor parse_linerange out of ddebug_parse_query |
| |
On Sat 2020-06-13 09:57:24, Jim Cromie wrote: > make the code-block reusable to later handle "file foo.c:101-200" etc.
> This should be a 90%+ code-move, with minimal adaptations; reindent, > and scafolding.
This sentence sounds like the author did some hidden microoptimizations and potentially broke the code. It made me nervous.
But in fact, I do not see any real change except that the variable "first" does not longer need to be defined. So, it is just a code move.
In this case, I usually write:
This patch does not change the existing behavior.
Best Regards, Petr
|