Messages in this thread | | | From | Vladimir Oltean <> | Date | Mon, 15 Jun 2020 16:33:54 +0300 | Subject | Re: [PATCH v2 1/3] spi: spi-fsl-dspi: Fix external abort on interrupt in exit paths |
| |
On Mon, 15 Jun 2020 at 16:28, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Jun 15, 2020 at 04:14:06PM +0300, Vladimir Oltean wrote: > > On Mon, 15 Jun 2020 at 16:10, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > > > > > > > > > > It is a slightly different bug which so this patch should have a follow > > > up. > > > > > > Best regards, > > > Krzysztof > > > > > > > Why is it a different bug? It's the same bug. > > One bug is using devm-interface for shared interrupts and second is not > caring about suspend/resume. > > Best regards, > Krzysztof >
The problem is that you don't have a way to stop servicing a shared interrupt safely and on demand, before clk_disable_unprepare. So it's exactly the same problem on suspend and on remove. Avoiding to think about the suspend problem now means that you'll end up having an overall worse solution.
| |