Messages in this thread | | | Subject | Re: [PATCH v3] coccinelle: api: add kzfree script | From | Markus Elfring <> | Date | Mon, 15 Jun 2020 15:26:43 +0200 |
| |
… > +virtual context > +virtual patch > +virtual org > +virtual report
+virtual context, patch, org, report
Is such a SmPL code variant more succinct?
… > +if (...) > + \(memset@ok\|memzero_explicit@ok\)(...);
Would you like to tolerate any extra source code around such a function call in an if branch?
… > +( > +* memset@m((T)E, 0, ...); > +| > +* memzero_explicit@m((T)E, ...); > +) …
I suggest to move a semicolon.
+( +*memset@m((T)E, 0, ...) +| +*memzero_explicit@m((T)E, ...) +);
… > +- \(kfree\|vfree\|kvfree\)(E); > ++ kvfree_sensitive(E, size); …
Would you like to increase the precision a bit for the change specification?
+-\(kfree\|vfree\|kvfree\) ++kvfree_sensitive + (E ++ , size + );
… > +( > +- kfree(E); > ++ kzfree(E); > +| > +- \(vfree\|kvfree\)(E); > ++ kvfree_sensitive(E, size); > +) …
+( +-kfree ++kzfree + (E) +| +-\(vfree\|kvfree\) ++kvfree_sensitive + (E ++ , size + ) +);
… > +coccilib.org.print_todo(p[0], > + "WARNING: opportunity for kzfree/kvfree_sensitive")
I suggest to align the second function parameter.
+coccilib.org.print_todo(p[0], + "WARNING: opportunity for kzfree/kvfree_sensitive")
Regards, Markus
| |