Messages in this thread | | | Date | Mon, 15 Jun 2020 12:14:43 +0200 | From | Thomas Bogendoerfer <> | Subject | Re: [PATCH] MIPS: Do not flush tlb when setting pmd entry |
| |
On Wed, Jun 03, 2020 at 05:42:13PM +0800, Bibo Mao wrote: > Function set_pmd_at is to set pmd entry, if tlb entry need to > be flushed, there exists pmdp_huge_clear_flush alike function > before set_pmd_at is called. So it is not necessary to call > flush_tlb_all in this function.
have you checked all set_pmd_at() calls ? I found a few case where it's not clear to me, if tlb flushing is done... If you think this is still the right thing to do, please change arch/mips/mm/pgtable-32.c as well.
Thomas.
-- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
| |