Messages in this thread |  | | Subject | Re: [PATCH v4 2/3] venus: Make debug infrastructure more flexible | From | Stanimir Varbanov <> | Date | Mon, 15 Jun 2020 12:55:29 +0300 |
| |
Hi Greg,
On 6/14/20 9:37 AM, Greg KH wrote: > On Sun, Jun 14, 2020 at 01:39:18AM +0300, Stanimir Varbanov wrote: >> if (slot == -1) { >> - dev_dbg(inst->core->dev, "%s: no free slot\n", __func__); >> + VDBGH("no free slot for timestamp\n"); > > Again, no, you just lost a lot of valuable information by changing to a > different format (like driver, specific device, etc.). Please don't do > this, it just makes the information less than before.
OK, one of the reasons to use pr_debug inside VDBGH macro is to avoid having struct device *dev variable in every function with dev_dbg even when the function doesn't use it.
Are you fine with s/pr_debug/dev_dbg in VDBGX macros?
-- regards, Stan
|  |