lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ARM: dts: am5729: beaglebone-ai: fix rgmii phy-mode
From
Date


On 12/06/2020 01:09, Drew Fustini wrote:
> Since commit cd28d1d6e52e ("net: phy: at803x: Disable phy delay for
> RGMII mode") the networking is broken on the BeagleBone AI which has
> the AR8035 PHY for Gigabit Ethernet [0]. The fix is to switch from
> phy-mode = "rgmii" to phy-mode = "rgmii-rxid".
>
> Note: Grygorii Strashko made a similar phy-mode fix in 820f8a870f65 for
> other AM5729 boards.

commit ref is incorrect
>
> [0] https://github.com/beagleboard/beaglebone-ai/blob/master/BeagleBone-AI_sch.pdf
>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Grygorii Strashko <grygorii.strashko@ti.com>
> Fixes: cd28d1d6e52e ("net: phy: at803x: Disable phy delay for RGMII mode")

Pls change fixed tag to
520557d4854b ARM: dts: am5729: beaglebone-ai: adding device tree
as this board DTB was merged only in 5.8.

> Signed-off-by: Robert Nelson <robertcnelson@gmail.com>
> Signed-off-by: Drew Fustini <drew@beagleboard.org>
> ---
> arch/arm/boot/dts/am5729-beagleboneai.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/am5729-beagleboneai.dts b/arch/arm/boot/dts/am5729-beagleboneai.dts
> index 9877d7709d41..4c51c6b05e64 100644
> --- a/arch/arm/boot/dts/am5729-beagleboneai.dts
> +++ b/arch/arm/boot/dts/am5729-beagleboneai.dts
> @@ -505,7 +505,7 @@ &mac {
>
> &cpsw_emac0 {
> phy-handle = <&phy0>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-rxid";
> };
>
> &ocp {
>

Thanks, pls fix above and you can add my
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>

--
Best regards,
grygorii

\
 
 \ /
  Last update: 2020-06-15 11:36    [W:0.052 / U:0.692 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site