Messages in this thread | | | From | Navid Emamdoost <> | Date | Mon, 15 Jun 2020 01:13:09 -0500 | Subject | Re: [PATCH] drm/etnaviv: fix ref count leak via pm_runtime_get_sync |
| |
On Sun, Jun 14, 2020 at 4:48 AM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost > <navid.emamdoost@gmail.com> wrote: > > ... > > > + if (ret < 0) { > > > + pm_runtime_put(gpu->dev); > > Please, in all your patches fix this to be _put_noidle(). We wouldn't > bear the flag day of fixing these parts again. > Yes, I know that *now* behaviour is the same, but calling put here is > slightly inconsistent.
v2 is sent.
> > ... > > > + pm_runtime_put(gpu->dev); > > -- > With Best Regards, > Andy Shevchenko
-- Navid.
| |