lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v5 07/27] clk: bcm: rpi: Remove global pllb_arm clock pointer
    Date
    The pllb_arm clk_hw pointer in the raspberry_clk structure isn't used
    anywhere but in the raspberrypi_register_pllb_arm.

    Let's remove it, this will make our lives easier in future patches.

    Cc: Michael Turquette <mturquette@baylibre.com>
    Cc: Stephen Boyd <sboyd@kernel.org>
    Cc: linux-clk@vger.kernel.org
    Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
    Reviewed-by: Stephen Boyd <sboyd@kernel.org>
    Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
    Signed-off-by: Maxime Ripard <maxime@cerno.tech>
    ---
    drivers/clk/bcm/clk-raspberrypi.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
    index 5f0d4875e145..b21dd6ddc4fe 100644
    --- a/drivers/clk/bcm/clk-raspberrypi.c
    +++ b/drivers/clk/bcm/clk-raspberrypi.c
    @@ -40,7 +40,6 @@ struct raspberrypi_clk {
    unsigned long max_rate;

    struct clk_hw pllb;
    - struct clk_hw *pllb_arm;
    struct clk_lookup *pllb_arm_lookup;
    };

    @@ -246,12 +245,12 @@ static int raspberrypi_register_pllb_arm(struct raspberrypi_clk *rpi)
    dev_err(rpi->dev, "Failed to initialize pllb_arm\n");
    return ret;
    }
    - rpi->pllb_arm = &raspberrypi_clk_pllb_arm.hw;

    - rpi->pllb_arm_lookup = clkdev_hw_create(rpi->pllb_arm, NULL, "cpu0");
    + rpi->pllb_arm_lookup = clkdev_hw_create(&raspberrypi_clk_pllb_arm.hw,
    + NULL, "cpu0");
    if (!rpi->pllb_arm_lookup) {
    dev_err(rpi->dev, "Failed to initialize pllb_arm_lookup\n");
    - clk_hw_unregister_fixed_factor(rpi->pllb_arm);
    + clk_hw_unregister_fixed_factor(&raspberrypi_clk_pllb_arm.hw);
    return -ENOMEM;
    }

    --
    git-series 0.9.1
    \
     
     \ /
      Last update: 2020-06-15 10:43    [W:4.253 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site