lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch] mtd: set master partition panic write flag
Hi Kamal,

Kamal Dasu <kdasu.kdev@gmail.com> wrote on Sat, 13 Jun 2020 02:49:31
-0400:

> Can you please accept this if there are no objections.
>
> Kamal
>
> > On May 4, 2020, at 7:54 PM, Kamal Dasu <kdasu.kdev@gmail.com> wrote:
> >
> > Check and set master panic write flag so that low level drivers
> > can use it to take required action to ensure oops data gets written
> > to assigned mtdoops device partition.
> >
> > Signed-off-by: Kamal Dasu <kdasu.kdev@gmail.com>
> > ---
> > drivers/mtd/mtdcore.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 2916674208b3..7e37ed2f38ea 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -1235,8 +1235,8 @@ int mtd_panic_write(struct mtd_info *mtd, loff_t to, size_t len, size_t *retlen,
> > return -EROFS;
> > if (!len)
> > return 0;
> > - if (!mtd->oops_panic_write)
> > - mtd->oops_panic_write = true;
> > + if (!master->oops_panic_write)
> > + master->oops_panic_write = true;
> >
> > return master->_panic_write(master, mtd_get_master_ofs(mtd, to), len,
> > retlen, buf);
> > --
> > 2.17.1
> >

I thing we missed it. However, shouldn't we have a Cc:/Fixes: pair of
tags here? We could send it as part of a fixes PR then.

Thanks,
Miquèl

\
 
 \ /
  Last update: 2020-06-15 09:22    [W:0.161 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site