lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH] net: fec: fix ref count leaking when pm_runtime_get_sync fails
Date
From: David Miller <davem@davemloft.net> Sent: Tuesday, June 16, 2020 4:42 AM
> From: Navid Emamdoost <navid.emamdoost@gmail.com>
> Date: Sun, 14 Jun 2020 00:38:01 -0500
>
> > in fec_enet_mdio_read, fec_enet_mdio_write, fec_enet_get_regs,
> > fec_enet_open and fec_drv_remove, pm_runtime_get_sync is called which
> > increments the counter even in case of failure, leading to incorrect
> > ref count. In case of failure, decrement the ref count before returning.
> >
> > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com>
>
> This does not apply to the net tree.

Wolfram Sang wonder if such de-reference can be better handled by pm runtime core code.
https://lkml.org/lkml/2020/6/14/76


\
 
 \ /
  Last update: 2020-06-16 04:04    [W:0.668 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site