lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v4 3/3] btrfs: Use kfree() in btrfs_ioctl_get_subvol_info()
    Date
    In btrfs_ioctl_get_subvol_info(), there is a classic case where kzalloc()
    was incorrectly paired with kzfree(). According to David Sterba, there
    isn't any sensitive information in the subvol_info that needs to be
    cleared before freeing. So kfree_sensitive() isn't really needed,
    use kfree() instead.

    Reported-by: David Sterba <dsterba@suse.cz>
    Signed-off-by: Waiman Long <longman@redhat.com>
    ---
    fs/btrfs/ioctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
    index f1dd9e4271e9..e8f7c5f00894 100644
    --- a/fs/btrfs/ioctl.c
    +++ b/fs/btrfs/ioctl.c
    @@ -2692,7 +2692,7 @@ static int btrfs_ioctl_get_subvol_info(struct file *file, void __user *argp)
    btrfs_put_root(root);
    out_free:
    btrfs_free_path(path);
    - kfree_sensitive(subvol_info);
    + kfree(subvol_info);
    return ret;
    }

    --
    2.18.1
    \
     
     \ /
      Last update: 2020-06-16 04:00    [W:6.408 / U:0.156 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site