Messages in this thread |  | | From | jim.cromie@gmail ... | Date | Mon, 15 Jun 2020 16:37:52 -0600 | Subject | Re: [PATCH v2 10/24] dyndbg: refactor parse_linerange out of ddebug_parse_query |
| |
On Mon, Jun 15, 2020 at 7:37 AM Petr Mladek <pmladek@suse.com> wrote: > > On Sat 2020-06-13 09:57:24, Jim Cromie wrote: > > make the code-block reusable to later handle "file foo.c:101-200" etc. > > > This should be a 90%+ code-move, with minimal adaptations; reindent, > > and scafolding. > > This sentence sounds like the author did some hidden > microoptimizations and potentially broke the code. > It made me nervous. > > But in fact, I do not see any real change except that the variable > "first" does not longer need to be defined. So, it is just a code move. > > In this case, I usually write: > > This patch does not change the existing behavior.
I see your point.
it was code move, reindent, add function wrapper, add call, compile I just dont recall if I had to touch anything else, add/move var decls etc.
|  |