lkml.org 
[lkml]   [2020]   [Jun]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 02/25] mm: Introduce mm_fault_accounting()
    On Mon, Jun 15, 2020 at 3:16 PM Peter Xu <peterx@redhat.com> wrote:
    >
    > Provide this helper for doing memory page fault accounting across archs. It
    > can be defined unconditionally because perf_sw_event() is always defined, and
    > perf_sw_event() will be a no-op if !CONFIG_PERF_EVENTS.

    Well, the downside is that now it forces a separate I$ miss and all
    those extra arguments because it's a out-of-line function and the
    compiler won't see that they all go away.

    Yeah, maybe some day maybe we'll have LTO and these kinds of things
    will not matter. And maybe they already don't. But it seems kind of
    sad to basically force non-optimal code generation from this series.

    Why would you export the symbol, btw? Page fault handling is never a module.

    Linus

    \
     
     \ /
      Last update: 2020-06-16 00:33    [W:4.255 / U:1.224 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site