Messages in this thread |  | | From | jim.cromie@gmail ... | Date | Mon, 15 Jun 2020 16:18:38 -0600 | Subject | Re: [PATCH v2 23/24] kset-example: add pr_debug()s for easy visibility of its operation |
| |
On Sun, Jun 14, 2020 at 12:05 AM Greg KH <gregkh@linuxfoundation.org> wrote: > > On Sat, Jun 13, 2020 at 09:57:37AM -0600, Jim Cromie wrote: > > put pr_debug()s into most functions, to easily see code operate when > > module is loaded and used. > > > > #> dmesg -w & > > #> modprobe kset-example dyndbg=+pfml > > #> cat /sys/kernel/kset-example/*/* > > ---
> > static int __init example_init(void) > > { > > + pr_debug("called"); > > Why??? If you want to do something like this, use ftrace, that is what > it is for. > > thanks, > > greg k-h
mostly I needed an easy place to try out pr_debug_n in the next patch. if that next patch seems like a good anti-pattern for pr_debug_n use/misuse, then I could combine the 2, and add a 'dont do this, use ftrace' comment too. or not, of course.
|  |