Messages in this thread | | | Date | Mon, 15 Jun 2020 20:26:30 +0100 | From | Mark Brown <> | Subject | Re: [PATCH v2] spi: bcm2835: Enable shared interrupt support |
| |
On Mon, Jun 15, 2020 at 06:31:58PM +0100, Robin Murphy wrote:
> Now that I've been inclined to go and look up the documentation, are we sure > this so-very-contentious check is even correct? From my reading of things > we're checking whether the RXR interrupt function is *enabled*, which still > says nothing about whether either condition for the interrupt being > *asserted* is true (RXR = 1 or DONE = 1). Thus if more than one SPI instance > is active at once we could still end up trying to service an IRQ on a > controller that didn't raise it.
OK, I've pulled the patch from the queue for now :/ [unhandled content-type:application/pgp-signature] | |