Messages in this thread | | | Date | Mon, 15 Jun 2020 08:50:00 +0200 | From | Krzysztof Kozlowski <> | Subject | Re: [PATCH v2 1/2] i2c: imx: Fix PM runtime inbalance in probe error path |
| |
On Sun, Jun 14, 2020 at 12:29:03PM +0200, Krzysztof Kozlowski wrote: > When pm_runtime_get_sync() fails in probe(), the error path should not > call pm_runtime_put_noidle(). This would lead to inbalance in > usage_count. > > Fixes: 588eb93ea49f ("i2c: imx: add runtime pm support to improve the performance") > Cc: <stable@vger.kernel.org> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > Changes since v1: > 1. New patch
This patch is not correct because the runtime usage counter is increased always, also on failures.
It can be dropped.
Best regards, Krzysztof
| |