Messages in this thread | | | Subject | Re: [PATCH] Input: bma150: fix ref count leak in bma150_open | From | Markus Elfring <> | Date | Sun, 14 Jun 2020 11:17:53 +0200 |
| |
> in bma150_open, …
* Can the term “reference count” become relevant also for this commit message besides other possible adjustments?
* Will the tag “Fixes” become helpful?
… > +++ b/drivers/input/misc/bma150.c … > @@ -357,10 +357,13 @@ static int bma150_open(struct input_dev *input) > if (bma150->mode != BMA150_MODE_NORMAL) { > error = bma150_set_mode(bma150, BMA150_MODE_NORMAL); > if (error) > - return error; > + goto out; > } > > return 0; > +out: > + pm_runtime_put(&bma150->client->dev); > + return error; > } …
Perhaps use the label “put_runtime” instead?
Regards, Markus
| |