lkml.org 
[lkml]   [2020]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set()
    From
    Date
    On 2020/6/15 7:22, zzuedu2000@163.com wrote:
    > On Sun, 2020-06-14 at 18:10 +0800, James.Bottomley@xxxxxxx wrote:
    >
    >> it's arguable that having two statements instead of one makes the code
    >> marginally more readable.
    >
    > Above the function there is a similar line of code:
    > l = it->tcset_pos->next;
    > One line of code makes the code style consistent and more readable
    >

    It would be much better if you are fixing a bug or developing a new feature
    and while at it you do this cleanup conveniently, but this patch alone has
    little value.

    \
     
     \ /
      Last update: 2020-06-15 03:12    [W:5.744 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site