Messages in this thread | | | Subject | Re: [PATCH] cgroup: Refactor two assignments in css_task_iter_next_css_set() | From | James Bottomley <> | Date | Sun, 14 Jun 2020 11:10:08 -0700 |
| |
On Sun, 2020-06-14 at 10:28 +0800, zzuedu2000@163.com wrote: > From: Wei Fenghai <zzuedu2000@163.com> > > Combine two assignments for the variable ‘l’ into one statement.
The problem with this commit message isn't the description, we can all see what the change does, it's the justification. Why is there any reason to do this? My version of gcc does this as an optimization anyway, so the patch doesn't change to the binary output and it's arguable that having two statements instead of one makes the code marginally more readable.
Regards,
James
| |