lkml.org 
[lkml]   [2020]   [Jun]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: rtl8712: Addressed checkpatch.pl issues related to macro parameter wrapping in parentheses.
On Sun, Jun 14, 2020 at 02:51:25PM +0100, Ricardo Ferreira wrote:
> #define init_h2fwcmd_w_parm_no_rsp(pcmd, pparm, code) \
> do {\
> - INIT_LIST_HEAD(&pcmd->list);\
> - pcmd->cmdcode = code;\
> - pcmd->parmbuf = (u8 *)(pparm);\
> - pcmd->cmdsz = sizeof(*pparm);\
> - pcmd->rsp = NULL;\
> - pcmd->rspsz = 0;\
> + INIT_LIST_HEAD(&(pcmd)->list);\
> + (pcmd)->cmdcode = code;\
> + (pcmd)->parmbuf = (u8 *)((pparm));\
> + (pcmd)->cmdsz = sizeof(*(pparm));\
> + (pcmd)->rsp = NULL;\
> + (pcmd)->rspsz = 0;\
> } while (0)

Does that change really make any sense? checkpatch is a nice hint,
sometimes it is not correct...

\
 
 \ /
  Last update: 2020-06-14 16:06    [W:1.525 / U:0.140 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site