Messages in this thread | | | Date | Fri, 12 Jun 2020 22:25:30 -0400 | From | Joel Fernandes <> | Subject | Re: [RFC PATCH 11/13] sched: migration changes for core scheduling |
| |
On Fri, Jun 12, 2020 at 05:32:01PM -0400, Vineeth Remanan Pillai wrote: > > AFAIR, that's what v4 did: > > > > if (available_idle_cpu(cpu)) > > #ifdef CONFIG_SCHED_CORE > > if (sched_core_enabled(cpu_rq(cpu)) && > > (p->core_cookie == cpu_rq(cpu)->core->core_cookie)) > > break; > > #else > > break; > > #endif > > > This patch was initially not in v4 and this is a merging of 4 patches > suggested post-v4. During the initial round, code was like above. But since > there looked like a code duplication in the different migration paths, > it was consolidated into sched_core_cookie_match() and it caused this > extra logic to this specific code path. As you mentioned, I also feel > we do not need to check for core idleness in this path.
Ok, so I take it that you will make it so in v6 then, unless of course someone else objects.
thanks!
- Joel
| |