Messages in this thread | | | From | Miao-chen Chou <> | Date | Fri, 12 Jun 2020 16:51:57 -0700 | Subject | Re: [PATCH v3 4/7] Bluetooth: Add handler of MGMT_OP_REMOVE_ADV_MONITOR |
| |
Hi Jakub,
I uploaded v4 to address these. Thanks for the reminder.
Regards, Miao
On Fri, Jun 12, 2020 at 10:49 AM Jakub Kicinski <kuba@kernel.org> wrote: > > On Thu, 11 Jun 2020 23:15:26 -0700 Miao-chen Chou wrote: > > This adds the request handler of MGMT_OP_REMOVE_ADV_MONITOR command. > > Note that the controller-based monitoring is not yet in place. This > > removes the internal monitor(s) without sending HCI traffic, so the > > request returns immediately. > > > > The following test was performed. > > - Issue btmgmt advmon-remove with valid and invalid handles. > > > > Signed-off-by: Miao-chen Chou <mcchou@chromium.org> > > Still doesn't build cleanly with W=1 C=1 > > net/bluetooth/mgmt.c:4009:46: warning: incorrect type in argument 2 (different base types) > net/bluetooth/mgmt.c:4009:46: expected unsigned short [usertype] handle > net/bluetooth/mgmt.c:4009:46: got restricted __le16 [usertype] monitor_handle > net/bluetooth/mgmt.c:4018:29: warning: cast from restricted __le16
| |