Messages in this thread | | | From | Miao-chen Chou <> | Date | Fri, 12 Jun 2020 15:19:01 -0700 | Subject | Re: [PATCH v2 1/7] Bluetooth: Add definitions for advertisement monitor features |
| |
Hi Marcel,
The name in the mgmt-api.txt doc is "Add Advertisement Patterns Monitor Command", and Luiz changed the name from MGMT_OP_ADD_ADV_PATTERNS_MONITOR to MGMT_OP_ADD_ADV_MONITOR before applied. So we either change the doc or change the header file to match. Based on the outcome I may need to change the name in mgmt.h in the kernel patch.
Regards, Miao
On Fri, Jun 12, 2020 at 6:21 AM Marcel Holtmann <marcel@holtmann.org> wrote: > > Hi Miao-chen, > > > Thanks for reviewing. Please see v3 for the update. > > I am trying to settle down the name of Add Advertisement Pattern > > Monitor command with Luiz on the other thread. I will post the update > > here once it is sorted out. > > I thought the name was just fine. Especially in the discussed context that we might add another “Add” command for future vendors, but keep a single “Remove” command. > > Regards > > Marcel >
| |