Messages in this thread | | | Subject | Re: [PATCH 00/16] dynamic_debug: cleanups, 2 features | From | Jason Baron <> | Date | Fri, 12 Jun 2020 17:31:22 -0400 |
| |
On 6/5/20 12:26 PM, Jim Cromie wrote: > Patchset starts with 7 "cleanups"; > - it changes section name from vague "__verbose" to "__dyndbg" > - cleaner docs, drop obsolete comment & useless debug prints, refine > verbosity, fix a BUG_ON, ram reporting miscounts. > > It adds a few query parsing conveniences; > accept combined file:line & file:func forms > > file inode.c:100-200 # file & line-range > file inode.c:start_* # file & function >
So I like the shortened notation there.
> Then it expands flags: > > Adds 'u' user flag, allowing user to compose an arbitrary set of > callsites by marking them with 'u', without altering current > print-modifying flags. > > Adds 'PFMLTU' flags, which negate their lower-case counterparts. > > Extends flags-spec with filter-flags, which select callsites for > modification based upon their current flags. This lets user activate > the set of callsites marked with 'u' in a batch. > > echo 'u+p' > control >
I'm wondering if users are really going to use these and how much they simplify things? Do you find them useful while debugging issues?
Especially now that now that we are looking to let people define groupings.
Thanks,
-Jason
| |