lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 4/4] drm/bridge: ti-sn65dsi86: Check the regmap return value when setting a GPIO
    Date
    The ti_sn_bridge_gpio_set() got the return value of
    regmap_update_bits() but didn't check it. The function can't return
    an error value, but we should at least print a warning if it didn't
    work.

    This fixes a compiler warning about setting "ret" but not using it.

    Fixes: 27ed2b3f22ed ("drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux")
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    ---

    Changes in v2:
    - GPIO %u because it's unsigned.

    drivers/gpu/drm/bridge/ti-sn65dsi86.c | 3 +++
    1 file changed, 3 insertions(+)

    diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
    index 1080e4f9df96..bd3eb0a09732 100644
    --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
    +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
    @@ -999,6 +999,9 @@ static void ti_sn_bridge_gpio_set(struct gpio_chip *chip, unsigned int offset,
    ret = regmap_update_bits(pdata->regmap, SN_GPIO_IO_REG,
    BIT(SN_GPIO_OUTPUT_SHIFT + offset),
    val << (SN_GPIO_OUTPUT_SHIFT + offset));
    + if (ret)
    + dev_warn(pdata->dev,
    + "Failed to set bridge GPIO %u: %d\n", offset, ret);
    }

    static int ti_sn_bridge_gpio_direction_input(struct gpio_chip *chip,
    --
    2.27.0.290.gba653c62da-goog
    \
     
     \ /
      Last update: 2020-06-12 21:32    [W:3.403 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site