lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] x86/entry: Ask RCU if it needs rcu_irq_{enter,exit}()
On Fri, Jun 12, 2020 at 11:27:21AM +0200, Thomas Gleixner wrote:
> "Paul E. McKenney" <paulmck@kernel.org> writes:
> > +static __always_inline bool rcu_needs_irq_enter(void)
> > +{
> > + return !IS_ENABLED(CONFIG_TINY_RCU) &&
> > + (context_tracking_enabled_cpu(smp_processor_id()) || is_idle_task(current));
>
> This reintroduces the #PF problem which started the whole conditional
> RCU entry discussion:
>
> https://lore.kernel.org/lkml/20200515235125.628629605@linutronix.de/
>
> and which made us all come to the conclusion that we can do it always
> conditional. No biscuit for you. :)

We can only be thankful that source-code control systems mean that my
coding session yesterday afternoon will have no permanent effect.

Let this be a lesson to all of you: Hacking RCU while sleep-deprived
is a really bad idea. ;-)

Thanx, Paul

\
 
 \ /
  Last update: 2020-06-12 15:58    [W:0.401 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site