lkml.org 
[lkml]   [2020]   [Jun]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/2] usb: phy: Add USB3 PHY support for Intel LGM SoC
On Fri, Jun 12, 2020 at 10:59:41AM +0800, Ramuthevar,Vadivel MuruganX wrote:
> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
>
> Add support for USB PHY on Intel LGM SoC.

Thank you for an update, looks pretty much good, my comments below.

...

> +static int get_flipped(struct tca_apb *ta, bool *flipped)
> +{
> + union extcon_property_value property;
> + int ret;
> +
> + ret = extcon_get_property(ta->phy.edev, EXTCON_USB_HOST,
> + EXTCON_PROP_USB_TYPEC_POLARITY, &property);
> + if (ret) {

> + dev_err(ta->phy.dev, "no polarity property from extcon\n");

(1)

> + return ret;
> + }
> +
> + *flipped = property.intval;
> +
> + return ret;
> +}

...

> + ret = get_flipped(ta, &flipped);
> + if (ret)
> + dev_err(ta->phy.dev, "no polarity property from extcon\n");

You already has a message in (1). You should decide which one to leave.

But note, if it's a fatal error, you have to return here, otherwise, if you
decide to leave message here, it should be not on error level.

> + connected = extcon_get_state(ta->phy.edev, EXTCON_USB_HOST);
> + if (connected == ta->connected)
> + return;
> +
> + ta->connected = connected;
> + if (connected) {
> + val = TCPC_VALID | FIELD_PREP(TCPC_MUX_CTL, MUX_USB);
> + if (flipped)
> + val |= TCPC_FLIPPED;
> + dev_info(ta->phy.dev, "connected%s\n", flipped ? " flipped" : "");
> + } else {
> + val = TCPC_DISCONN;
> + dev_info(ta->phy.dev, "disconnected\n");
> + }
> +
> + writel(val, ta->phy.io_priv + TCPC_OFFSET);
> +

> + if (ta->phy.set_vbus(&ta->phy, connected))
> + dev_err(ta->phy.dev, "failed to set VBUS\n");

Please, split it to
ret = ...;
if (ret)

> +}

...

> +static int vbus_notifier(struct notifier_block *nb,
> + unsigned long event, void *ptr)

Consider to put it on one line (you can also shrink the names of unused
parameters.

> +{
> + return NOTIFY_DONE;
> +}

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2020-06-12 15:18    [W:0.218 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site