Messages in this thread Patch in this message | | | From | Wolfram Sang <> | Subject | [PATCH] lib: update DEBUG_SHIRQ docs to match reality | Date | Fri, 12 Jun 2020 14:48:44 +0200 |
| |
There is no extra interrupt when registering a shared interrupt handler since 2011. Update the Kconfig text to make it clear and to avoid wrong assumptions when debugging issues found by it.
Fixes: 6d83f94db95c ("genirq: Disable the SHIRQ_DEBUG call in request_threaded_irq for now") Link: https://lore.kernel.org/linux-i2c/859e8211-2c56-8dd5-d6fb-33e4358e4128@pengutronix.de/T/#mf24d7070d7e0c8f17b6be6ceb51df94b7d7613b3 Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> ---
I'd think this could go in via one of tglx' trees?
lib/Kconfig.debug | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index ef675beccab1..50522d3a7770 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -845,10 +845,10 @@ config DEBUG_SHIRQ bool "Debug shared IRQ handlers" depends on DEBUG_KERNEL help - Enable this to generate a spurious interrupt as soon as a shared - interrupt handler is registered, and just before one is deregistered. - Drivers ought to be able to handle interrupts coming in at those - points; some don't and need to be caught. + Enable this to generate a spurious interrupt just before a shared + interrupt handler is deregistered (generating one when registering + is currently disabled). Drivers need to handle this correctly. Some + don't and need to be caught. menu "Debug Oops, Lockups and Hangs" -- 2.20.1
| |