Messages in this thread | | | From | Toke Høiland-Jørgensen <> | Subject | Re: [PATCH] xdp_rxq_info_user: Replace malloc/memset w/calloc | Date | Fri, 12 Jun 2020 14:06:50 +0200 |
| |
Joe Perches <joe@perches.com> writes:
> On Fri, 2020-06-12 at 08:42 +0200, Jesper Dangaard Brouer wrote: >> On Thu, 11 Jun 2020 20:36:40 -0400 >> Gaurav Singh <gaurav1086@gmail.com> wrote: >> >> > Replace malloc/memset with calloc >> > >> > Fixes: 0fca931a6f21 ("samples/bpf: program demonstrating access to xdp_rxq_info") >> > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> >> >> Above is the correct use of Fixes + Signed-off-by. >> >> Now you need to update/improve the description, to also >> mention/describe that this also solves the bug you found. > > This is not a fix, it's a conversion of one > correct code to a shorter one.
No it isn't - the original code memset()s before it checks the return from malloc(), so it's a potential NULL-pointer reference... Which the commit message should explain, obviously :)
-Toke
| |