Messages in this thread Patch in this message | | | Date | Fri, 12 Jun 2020 12:23:17 +0300 | From | Matti Vaittinen <> | Subject | [PATCH] regulator: Fix pickable ranges mapping |
| |
Pickable ranges mapping function never used range min selector. Thus existing drivers broke when proper linear_ranges functionality was taken in use. Fix this for now just by ignoring the minimum selector.
Fixes: commit 60ab7f4153b6 ("regulator: use linear_ranges helper") Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> ---
I noticed BD71847 voltage changes for BUCK3 did not work as expected. Setting voltage to 1050000 did not work even though this should be supported. It appears I broke pickable-ranges support with linear_ranges change. I expect the MAX77650 and BD71847/BD71850 to be broken.
drivers/regulator/helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/helpers.c b/drivers/regulator/helpers.c index e970e9d2f8be..e4bb09bbd3fa 100644 --- a/drivers/regulator/helpers.c +++ b/drivers/regulator/helpers.c @@ -486,7 +486,7 @@ int regulator_map_voltage_pickable_linear_range(struct regulator_dev *rdev, continue; } - ret = selector + sel; + ret = selector + sel - range->min_sel; voltage = rdev->desc->ops->list_voltage(rdev, ret); base-commit: 0b0c0bd818ef76a20f58c3cb1ac96a3056ccb681 -- 2.21.0
-- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ Thanks to Simon Glass for the translation =]
| |