Messages in this thread | | | Subject | Re: [PATCH] PCI: Loongson: Use DECLARE_PCI_FIXUP_EARLY for bridge_class_quirk() | From | Tiezhu Yang <> | Date | Fri, 12 Jun 2020 09:21:10 +0800 |
| |
On 06/12/2020 04:26 AM, Bjorn Helgaas wrote: > Subject line: > > PCI: loongson: Use DECLARE_PCI_FIXUP_EARLY for bridge_class_quirk() > > (Driver names are conventionally lower case.) > > Lorenzo will probably silently fix this when applying, so this is > mostly just a reminder in case you need to revise this or for future > patches. Hi Bjorn,
Thanks for your reminder, sorry for that. I will modify it and then send v2.
> > On Wed, Jun 10, 2020 at 10:39:50AM +0800, Tiezhu Yang wrote: >> Use DECLARE_PCI_FIXUP_EARLY instead of DECLARE_PCI_FIXUP_HEADER >> for bridge_class_quirk() in pci-loongson.c, otherwise the fixup >> has no effect. >> >> Fixes: 1f58cca5cf2b ("PCI: Add Loongson PCI Controller support") >> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> >> --- >> >> This patch is based on mips-next tree. >> >> drivers/pci/controller/pci-loongson.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/pci/controller/pci-loongson.c b/drivers/pci/controller/pci-loongson.c >> index 459009c..58b862a 100644 >> --- a/drivers/pci/controller/pci-loongson.c >> +++ b/drivers/pci/controller/pci-loongson.c >> @@ -37,11 +37,11 @@ static void bridge_class_quirk(struct pci_dev *dev) >> { >> dev->class = PCI_CLASS_BRIDGE_PCI << 8; >> } >> -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON, >> DEV_PCIE_PORT_0, bridge_class_quirk); >> -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON, >> DEV_PCIE_PORT_1, bridge_class_quirk); >> -DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_LOONGSON, >> +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_LOONGSON, >> DEV_PCIE_PORT_2, bridge_class_quirk); >> >> static void system_bus_quirk(struct pci_dev *pdev) >> -- >> 2.1.0 >>
| |