Messages in this thread | | | Subject | Re: [Cocci] [PATCH v2 4/4] coccinelle: api: add selfcheck for memdup_user rule | From | Denis Efremov <> | Date | Fri, 12 Jun 2020 00:25:53 +0300 |
| |
On 6/9/20 7:22 PM, Julia Lawall wrote: > > > On Mon, 8 Jun 2020, Denis Efremov wrote: > >> Check that the rule matches vmemdup_user implementation. >> memdup_user is out of scope because we are not matching >> kmalloc_track_caller() function. > > Is this a bit over-enginered?
Last patch it's just a PoC. Patches 1-3 are independent from 4.
> More precisely, even if it is nice to check > that the API definition has the expected behavior, does it make sense to > do it in one case but not the other?
Yes, I also don't like it. However, I doubt that we need to match kmalloc_track_caller.
Thanks, Denis
| |