Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 11 Jun 2020 23:04:07 +0200 | Subject | Re: [PATCH] net: ethernet: mtk-star-emac: simplify interrupt handling |
| |
czw., 11 cze 2020 o 21:51 David Miller <davem@davemloft.net> napisał(a): > > From: Bartosz Golaszewski <brgl@bgdev.pl> > Date: Thu, 11 Jun 2020 16:01:39 +0200 > > > Unfortunately after thorough testing of current mainline, we noticed the > > driver has become unstable under heavy load. While this is hard to > > reproduce, it's quite consistent in the driver's current form. > > Maybe you should work to pinpoint the actual problem before pushing forward > a solution?
Why would you assume I didn't? I've been trying to figure out this problem since Monday but since I'm not sure how much time I will be able to spend on this going forward and due to the fact that this is now upstream (and broken), I sent this patch. As I said: it doesn't impact performance nor is this solution inherently wrong - many drivers do it this way.
I will continue working on this driver on and off so I *do* intend on fixing it as well as extending it with more support, hence the FIXME and previous TODO.
Best regards, Bartosz
| |